Lwt awareness #125
Merged
Lwt awareness #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
reviewed
Apr 28, 2022
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/PreparedStatementIT.java
Show resolved
Hide resolved
|
@Lorak-mmk Please also look into #127 - we have one customer that wants this functionality. |
|
Now the tests are passing. |
This commit enables handling of "LWT prepared statements metadata mark" extension uses by Scylla. Only handshake is performed, to inform server that we want metadata mark to be sent. It is however still unused. More information about this extension can be found at: https://github.com/scylladb/scylla/blob/master/docs/design-notes/protocol-extensions.md
To avoid contention, we want to try primary replica first, then secondary and so on. More information: scylladb#24
|
#122 is now merged, so I rebased on scylla-4.x |
avelanarius
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on #122, so should get merged after it.
Fixes #24
PR is generally a port of commits mentioned in above issue, but modified to accommodate different architecture of driver 4.x, and also includes some integration tests.