Skip to content

tests: stop using set_keyspace in test_can_register_udt_before_conn… #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

fruch
Copy link

@fruch fruch commented Feb 15, 2024

…ecting

this test is doing multiple is using USE comamnd, seems like we are having
same race conditions with the applying of those, and getting the following
error once in a while:

>   raise self._final_exception
E   cassandra.InvalidRequest: Error from server: code=2200 [Invalid query] message="Unknown field 'is_cool' in value of user defined type user"

in this test we'll use full qulified names of the table with the keyspace
and not set_keyspsce (i.e. USE command)

Fixes: #264

@fruch fruch requested a review from Lorak-mmk February 15, 2024 07:19
@fruch
Copy link
Author

fruch commented Feb 15, 2024

Let take it for an actual run in CI (where the flakiness usually surface)

I'm still not total sure it's just a schema mismatch, and not issue with the handling of set_keyspace inside the driver. maybe similar to #190

@fruch fruch marked this pull request as ready for review February 20, 2024 14:57
@fruch fruch force-pushed the fix_udt_flaky_test_264 branch from 900902c to 3200b74 Compare February 22, 2024 14:55
@fruch
Copy link
Author

fruch commented Feb 22, 2024

CI is failing cause missing #300, we'll merge that and then give this one a run

@Lorak-mmk
Copy link

CI is failing cause missing #300, we'll merge that and then give this one a run

I merged #300

Let take it for an actual run in CI (where the flakiness usually surface)

I'm still not total sure it's just a schema mismatch, and not issue with the handling of set_keyspace inside the driver. maybe similar to #190

I wouldn't be surprised, I remember that set_keyspace handling was complicated (to say the least) in this driver.

…ecting

this test is doing multiple is using `USE` comamnd, seems like we are having
same race conditions with the applying of those, and getting the following
error once in a while:

```
>   raise self._final_exception
E   cassandra.InvalidRequest: Error from server: code=2200 [Invalid query] message="Unknown field 'is_cool' in value of user defined type user"
```

in this test we'll use full qulified names of the table with the keyspace
and not set_keyspsce (i.e. `USE` command)

Fixes: scylladb#264
@fruch fruch force-pushed the fix_udt_flaky_test_264 branch 2 times, most recently from ddec815 to f21c1b9 Compare February 25, 2024 17:10
@fruch
Copy link
Author

fruch commented Feb 25, 2024

@Lorak-mmk

I've changed this to stop using set_keyspace, that not the goal of that specific test, and seems like the source of it's instability

@Lorak-mmk
Copy link

Ok, then let's merge it, but first could you open an issue about set_keyspace being flaky and attach original code of this test there?

@fruch fruch changed the title tests: wait for schema agreement in test_can_register_udt_before_conn… tests: stop using set_keyspace in test_can_register_udt_before_conn… Feb 28, 2024
@fruch
Copy link
Author

fruch commented Feb 28, 2024

Ok, then let's merge it, but first could you open an issue about set_keyspace being flaky and attach original code of this test there?

raised the issue:
#302

@fruch fruch merged commit 8138dca into scylladb:master Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unstable][asyncore] test_can_register_udt_before_connecting unstable
2 participants