Skip to content

Make building pipeline less confusing #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Feb 18, 2025

Changes:

  1. Use matrix that is built from inputs.target
  2. Combine Overwrite steps for windows and MacOs+Linux
  3. Integrate aarch64 workflow into build-wheels
  4. Move out all cibuildwheel configuration to pyproject.toml
  5. Get rid of overwites for CIBW_SKIP
  6. Switch from macos-latest to macos-14 and from windows-latest to windows-2022
  7. Allow prerelase python for aarch64

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch 5 times, most recently from 2fb3cbe to 508dc5f Compare February 18, 2025 20:08
@dkropachev dkropachev requested a review from fruch February 18, 2025 20:18
@dkropachev dkropachev marked this pull request as ready for review February 18, 2025 20:20
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch 2 times, most recently from 38314b5 to 17bc12a Compare February 22, 2025 13:27
@dkropachev dkropachev changed the title Make building pipeline less confusing WIP: Make building pipeline less confusing Feb 22, 2025
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch from 17bc12a to d23183d Compare February 22, 2025 13:44
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch 6 times, most recently from 30e1980 to 7e277b3 Compare February 22, 2025 21:23
@dkropachev dkropachev changed the title WIP: Make building pipeline less confusing Make building pipeline less confusing Feb 22, 2025
@dkropachev
Copy link
Collaborator Author

@fruch @Lorak-mmk , guys please take a look

Copy link

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch from 7e277b3 to 0c814eb Compare February 23, 2025 10:59
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch from 0c814eb to 185bc9f Compare February 23, 2025 11:13
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch 3 times, most recently from ab3aba8 to 7d8e09e Compare February 23, 2025 13:31
@dkropachev dkropachev force-pushed the dk/cicd-make-build-target-less-confusing branch from 7d8e09e to 27ef3d5 Compare February 23, 2025 19:00
@dkropachev dkropachev merged commit 4447a0b into scylladb:master Feb 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants