Fix Clippy lints introduced in Clippy 0.1.85 #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy 0.1.85 (introduced in Rust 1.85.0) adds or updates a few lints, causing builds to fail.
In particular the changes to the
clippy::useless_conversion
lint that was changed in rust-lang/rust-clippy#13756 and theclippy::precedence
lint that was changed in rust-lang/rust-clippy#13743 are causing issues.The precedence fix changes things that could impact functionality, so tests were added. I have not run any benchmarks, but https://godbolt.org/z/j78fETzbT seems to indicate better codegen with the new code.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.