Skip to content

Conversation

gsson
Copy link

@gsson gsson commented Feb 22, 2025

Clippy 0.1.85 (introduced in Rust 1.85.0) adds or updates a few lints, causing builds to fail.

In particular the changes to the clippy::useless_conversion lint that was changed in rust-lang/rust-clippy#13756 and the clippy::precedence lint that was changed in rust-lang/rust-clippy#13743 are causing issues.

The precedence fix changes things that could impact functionality, so tests were added. I have not run any benchmarks, but https://godbolt.org/z/j78fETzbT seems to indicate better codegen with the new code.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Copy link

cargo semver-checks found no API-breaking changes in this PR! 🎉🥳
Checked commit: de6a337

@Lorak-mmk Lorak-mmk merged commit d190409 into scylladb:main Feb 24, 2025
11 checks passed
@gsson gsson deleted the clippy-0.1.85 branch February 25, 2025 16:56
@Lorak-mmk Lorak-mmk mentioned this pull request Mar 4, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants