book: fix book workflow #616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The book workflow suddenly started failing at the `mdbook test` step. After a brief investigation it looks like `mdbook` doesn't work properly when flags are passed before the main argument. Because of this the old command: ```bash mdbook test -L target/debug/deps docs ``` Started failing as if the `docs` argument wasn't passed at all. It used the default book directory and couldn't find a book there because the book is in the `docs` directory. Error: Couldn't open SUMMARY.md in "/home/runner/work/scylla-rust-driver/scylla-rust-driver/src On the other hand this works properly: ```bash mdbook test docs -L target/debug/deps ``` So I changed the order of arguments to fix the problem. Signed-off-by: Jan Ciolek <[email protected]>
|
Opened rust-lang/mdBook#1958 because this looks like a mdbook bug |
|
The newest verison of the book has fixed the bug, so this PR is no longer needed. The CI passes on master without modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The book workflow suddenly started failing at the
mdbook teststep.After a brief investigation it looks like
mdbookdoesn't work properly when flags are passed before the main argument.Because of this the old command:
mdbook test -L target/debug/deps docsStarted failing as if the
docsargument wasn't passed at all. It used the default book directory and couldn't find a book there because the book is in thedocsdirectory.Error: Couldn't open SUMMARY.md in "/home/runner/work/scylla-rust-driver/scylla-rust-driver/src
On the other hand this works properly:
mdbook test docs -L target/debug/depsSo I changed the order of arguments to fix the problem.