Theme integration #612
Theme integration #612
Conversation
SK1PPR
force-pushed
the
theme-integration
branch
from
854061d to
a0662f4
Compare
SK1PPR
force-pushed
the
theme-integration
branch
from
a0662f4 to
88dcf3e
Compare
SK1PPR
force-pushed
the
theme-integration
branch
from
88dcf3e to
a211c1f
Compare
|
@twaritwaikar I have added a 3rd party header for reading the json files, for now placed it in the same directory only, but should I place it somewhere else? maybe make a 3rdparty folder. Also please review current changes |
|
@SK1PPR We already have a JSON library present here - https://github.com/sdslabs/Rootex/tree/dev/rootex%2Fvendor%2FJSON You can try to find examples of how we use it and just do the same here |
|
You probably have the nholmann/json library in the scope. This is how it's utilized in types.h - https://github.com/sdslabs/Rootex/blob/dev/rootex%2Fcommon%2Ftypes.h#L158 types.h should be already included in the scope. If not, just add it and you will have the JSON namespace from there |
|
Clang-format 11 use ho raha in the gh-action, and currently 20 h isiliye failed aa raha, mai isko theek krne ka dekhta |
|
Ab toh nhi pata why it is failing clang-format ka test, mai isko ete baad dekhta |
| @@ -170,6 +172,18 @@ bool EditorSystem::initialize(const JSON::json& systemData) | |||
| colors[ImGuiCol_ModalWindowDimBg] = ImVec4(1.00f, 0.98f, 0.95f, 0.73f); | |||
| } | |||
|
|
|||
| // Load json theme data | |||
| for (const auto& entry : std::filesystem::directory_iterator("editor/themes")) | |||
There was a problem hiding this comment.
Register this into types.h too. We avoid writing down std::* around the engine. Typedef it to DirectoryIterator most likely.
| struct ThemeDefinition | ||
| { | ||
| String m_Name; | ||
| String m_filePath; |
No description provided.