Skip to content

Update pandas dependency range #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csala opened this issue Aug 11, 2021 · 2 comments · Fixed by #279
Closed

Update pandas dependency range #266

csala opened this issue Aug 11, 2021 · 2 comments · Fixed by #279
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@csala
Copy link
Contributor

csala commented Aug 11, 2021

Copulas currently does not support pandas>=1.1.5, which does not include the newest versions.

We should investigate why blocks us from using the latest versions and adapt the code if necessary.

@csala csala added the internal The issue doesn't change the API or functionality label Aug 11, 2021
@fealho
Copy link
Member

fealho commented Aug 11, 2021

Currently, if we run pytest with pandas > 1.1.5 three test cases fail. After some investigation, I believe they fail because of this update on their side. This change modifies the behavior of the corr() function which we use here:

self.tau_mat = self.data.corr(method='kendall').values

We then use the tau matrix in the fitting process:

self.tree.fit(0, 4, self.tau_mat, self.u_matrix)

Since the pandas update changes our tau matrix, which in turn changes the fitting procedure, we end up generating a different tree in the end. Since the test cases expect the tree generated by the old pandas, they fail the current test.

In summary, after we correct the test cases that fail, I believe there will be no problems in updating pandas for all our libraries.

@amontanez24 amontanez24 added this to the 0.5.2 milestone Nov 5, 2021
@amontanez24 amontanez24 modified the milestones: 0.5.2, 0.6.0 Nov 5, 2021
@rivendellx
Copy link

For my other project, I must use pandas 0.25.4. just wondering would it cause any issues in the correlation/covariance/tau_mat matrix produced by the newest copulas package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants