Skip to content

Upgrade dependency ranges #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csala opened this issue Aug 11, 2021 · 2 comments
Closed

Upgrade dependency ranges #69

csala opened this issue Aug 11, 2021 · 2 comments
Assignees
Milestone

Comments

@csala
Copy link
Contributor

csala commented Aug 11, 2021

The latest versions of the libraries pandas, sktime and pomegranate are not supported by sdmetrics:

Library Upper bound (unsupported) Latest release
pandas 1.1.5 1.3.1
pomegranate 0.14.2 0.14.5
sktime 0.6 0.7.0

We should investigate why and update the code if necessary to support them.

@fealho
Copy link
Member

fealho commented Aug 11, 2021

The maximum requirement for pandas comes from Copulas, so I think that should be discussed here.

The issue with pomegranate is that there are no wheels for py36 after 0.14.1.

sktime runs into a cannot import name 'TimeSeriesForestClassifier' which I'm currently investigating.

@katxiao
Copy link
Contributor

katxiao commented Nov 2, 2021

sdv-dev/Copulas#266 addresses pandas, and #81 addresses sktime. Since pomegranate is now marked as optional, I am going to close this issue. We can open another issue if we want to bump the optional pomegranate range after we stop supporting py36.

@katxiao katxiao closed this as completed Nov 2, 2021
@katxiao katxiao self-assigned this Nov 2, 2021
@pvk-developer pvk-developer added this to the 0.4.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants