Skip to content

Generate action attempts ref #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

DebbieAtSeam
Copy link
Member

No description provided.

@DebbieAtSeam DebbieAtSeam requested review from a team as code owners June 25, 2025 04:22
@DebbieAtSeam
Copy link
Member Author

DebbieAtSeam commented Jun 25, 2025

@razor-x Do I have the description for the action_attempt resource in the wrong place? It's not rendering in this PR. Is action_attempt a special case such that the description/overview needs to go in paths.yaml?

@razor-x
Copy link
Member

razor-x commented Jun 25, 2025

@razor-x Do I have the description for the action_attempt resource in the wrong place? It's not rendering in this PR. Is action_attempt a special case such that the description/overview needs to go in paths.yaml?

That looks correct. Might be a bug in blueprint setting the correct description. @andrii-balitskyi could use some support here if you can 🙏🏻

@andrii-balitskyi
Copy link
Contributor

@razor-x @DebbieAtSeam I think it has something to do with action_attempt not being a member of blueprint.resources because we handle it separately in blueprint.actionAttempts.

I opened a draft PR a while ago where I added separate handling for action_attempt resource in docs (link). We either do something like this, or adjust the blueprint.

@DebbieAtSeam
Copy link
Member Author

I opened a draft PR a while ago where I added separate handling for action_attempt resource in docs (link). We either do something like this, or adjust the blueprint.

Many thanks, @andrii-balitskyi! I thought that you'd already done something cool for action attempts, so thanks for pointing us to your PR! @razor-x or @mikewuu, is it possible to implement what Andrii has done?

Thanks!

@DebbieAtSeam
Copy link
Member Author

...or should I just add the description for action attempts to paths.yaml as an easy workaround?

@DebbieAtSeam DebbieAtSeam marked this pull request as draft June 27, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants