Revert PR 5592 #5637
Closed
Revert PR 5592 #5637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once you're done, please squash all commits into a single commit that has a sensible commit message. Thanks! |
|
@sebastianbergmann all done. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 10.5 #5637 +/- ##
============================================
- Coverage 89.41% 89.39% -0.03%
- Complexity 6412 6413 +1
============================================
Files 682 682
Lines 20399 20397 -2
============================================
- Hits 18240 18234 -6
- Misses 2159 2163 +4 ☔ View full report in Codecov by Sentry. |
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I agree with @mvorisek: #5592 fixed a breaking change that was introduced PHPUnit 10.0.0 (compared to PHPUnit 8 and PHPUnit 9) that was unfortunately not caught before. |
|
@sebastianbergmann no worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #5592 as requested here: #5592 (comment)