Do not run tests when code coverage analysis is requested but code coverage data cannot be collected #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 14, 2025
|
|
||
| 1) XDEBUG_MODE=coverage (environment variable) or xdebug.mode=coverage (PHP configuration setting) has to be set | ||
|
|
||
| No tests executed! |
There was a problem hiding this comment.
here we see we get the warning while no more tests are run -> immediate feedback
staabm
commented
Jun 14, 2025
| */ | ||
| namespace PHPUnit\Runner; | ||
|
|
||
| enum CodeCoverageInitializationStatus |
There was a problem hiding this comment.
Suggested change
| enum CodeCoverageInitializationStatus | |
| /** | |
| * @internal This class is not covered by the backward compatibility promise for PHPUnit | |
| */ | |
| enum CodeCoverageInitializationStatus |
?
|
should be good to go |
sebastianbergmann
added
type/enhancement
sebastianbergmann
changed the title
sebastianbergmann
changed the title
|
Merged manually, thanks. |
|
Thanks 🙏 |
sebastianbergmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doing a process restart and persisting all possible cli args etc, while not just re-using composer/xdebug-handler and re-implementing everything is not a useful way and requires lots of code we would need to maintain.
therefore I figured I would just make sure that phpunit exits early instead of running all tests, when the coverage driver cannot be activated
closes #6233