Check if tcpdump binary exists #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
reviewed
Mar 26, 2019
|
I do not think that we use libpcap anywhere else to compile filters. I have not plan to experiment with that =)
|
gpotter2
previously approved these changes
Mar 28, 2019
guedou
force-pushed
the
check_tcpdump_calls
branch
from
c2ab06b to
0b3b308
Compare
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
- Coverage 86.34% 86.31% -0.03%
==========================================
Files 197 197
Lines 44460 44468 +8
==========================================
- Hits 38387 38381 -6
- Misses 6073 6087 +14
|
guedou
force-pushed
the
check_tcpdump_calls
branch
2 times, most recently
from
ccea004 to
6bb6409
Compare
guedou
force-pushed
the
check_tcpdump_calls
branch
from
6bb6409 to
d58bba3
Compare
gpotter2
reviewed
Apr 20, 2019
gpotter2
force-pushed
the
check_tcpdump_calls
branch
from
d58bba3 to
135ed89
Compare
guedou
force-pushed
the
check_tcpdump_calls
branch
from
75cd7b8 to
bb35522
Compare
|
I broke this PR with a bad rebase =/ |
|
@gpotter2 if you have a local copy, could you create another PR? |
gpotter2
force-pushed
the
check_tcpdump_calls
branch
from
bb35522 to
135ed89
Compare
gpotter2
force-pushed
the
check_tcpdump_calls
branch
from
135ed89 to
3f5e7ca
Compare
|
@guedou I did have a copy. I've restored this PR and rebased it against master |
|
@gpotter2 thanks! It looks good to me. I restarted the failing Travis test. You can merge the PR when it pass. |
gpotter2
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues discovered while investigating #1929.