-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix race conditions on Init #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That is not my definition of a simple fix =) I am ok with the PR if it fixes the initial issue, however I still think that a race condition can appear. |
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
+ Coverage 87.12% 87.29% +0.17%
==========================================
Files 198 199 +1
Lines 44679 45184 +505
==========================================
+ Hits 38926 39445 +519
+ Misses 5753 5739 -14
|
@gpotter2 could you rebase? |
Do you know if this actually fixes the issue ? |
I am able to quickly (less than 50 runs of the PoC with n set to 2000) reproduce the issue on master on two different setups. 1000 runs of the same PoC with this branch did not trigger the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on two different setups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that it breaks test in fields.uts
. Can you have a look?
Right. |
@guedou |
fixes #1966