-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Smarter interface selection when sending one packet #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An alternative implementation could be to use a disctinct socket per interface. It likely means to open socket inside |
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
- Coverage 87.2% 87.19% -0.01%
==========================================
Files 197 197
Lines 44506 44515 +9
==========================================
+ Hits 38810 38816 +6
- Misses 5696 5699 +3
|
@gpotter2 ready to be merged |
@gpotter2 thanks! I applied your comments. |
Maybe this could be applied to |
@gpotter2 may answer will be the same as my two first comments. |
Got it. All Good to me then |
This PR fixes #1975.
sr()
andsrloop()
are not candidates for this fix as they could be used to send packets to destinations available from different network interfaces. I do not think that it is a good idea to iterate over packets to select the interface, then to iterate again to send them.