-
Notifications
You must be signed in to change notification settings - Fork 53
Add HSMSigner #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add HSMSigner #472
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
917a75b
signer: add HSMSigner and HSMKey
lukpueh 5a7700f
signer: remove HSMKey but keep from_hsm method
lukpueh 4afcb85
signer: move HSMSigner to _hsm_signer.py
lukpueh c092766
signer: change hsm keyid data type to int
lukpueh 1bc3dd6
signer: open session in sign method
lukpueh c56f516
signer: run HSM tests as part of regular tests
lukpueh 1a6d9c4
signer: add pkcs11 lib pseudo-singleton
lukpueh 96d80f3
signer: implement basic "hsm" scheme
lukpueh 13bf562
signer: fix mypy and linter issues
lukpueh 60679b7
signer: add public key export method to HSMSigner
lukpueh 0928ceb
signer: list one extra dependency per library
lukpueh d6d1509
signer: clean up _hsm_signer.py
lukpueh 5cb6a69
signer: take pin not secrets handler in HSMSigner
lukpueh 265f7c9
signer: clean up test_hsm.py
lukpueh 20928d0
signer: minor doc fixes
lukpueh 8283650
signer: take secrets handler not pin in HSMSigner
lukpueh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,3 +51,4 @@ check-quote-consistency=yes | |
|
||
[TYPECHECK] | ||
generated-members=shake_128s.* | ||
ignored-modules=PyKCS11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,23 @@ | ||
cffi==1.15.1 # via cryptography, pynacl | ||
cryptography==38.0.3 | ||
pycparser==2.21 # via cffi | ||
# | ||
# This file is autogenerated by pip-compile with python 3.8 | ||
# To update, run: | ||
# | ||
# pip-compile --output-file=requirements-pinned.txt requirements.txt | ||
# | ||
asn1crypto==1.5.1 | ||
# via -r requirements.txt | ||
cffi==1.15.1 | ||
# via | ||
# cryptography | ||
# pynacl | ||
# pyspx | ||
cryptography==38.0.3 ; python_version >= "3" | ||
# via -r requirements.txt | ||
pycparser==2.21 | ||
# via cffi | ||
pykcs11==1.5.11 | ||
# via -r requirements.txt | ||
pynacl==1.5.0 | ||
six==1.16.0 # via pynacl | ||
PySPX==0.5.0 | ||
# via -r requirements.txt | ||
pyspx==0.5.0 | ||
# via -r requirements.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,3 +34,5 @@ | |
cryptography >= 37.0.0; python_version >= '3' | ||
pynacl | ||
PySPX | ||
PyKCS11 | ||
asn1crypto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like this isn't the correct way to use this system. pykcs11 without asn1 doesn't make sense so why offer that as option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asn1crypto
is only an immediate dependency for pubkey export. For signing we don't use it.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree, telling users to run
is not a lot better, than
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listing extra dependencies by feature, otoh, seems prone to redundancy.
cryptography
, for instance, is used for many different features.