add runAttempt to default s3Prefix #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janeyx99
reviewed
Mar 22, 2022
src/upload-artifact.ts
Outdated
| const s3Prefix = | ||
| inputs.s3Prefix === '' | ||
| ? `${github.context.repo.owner}/${github.context.repo.repo}/${github.context.runId}/${inputs.artifactName}` | ||
| ? `${github.context.repo.owner}/${github.context.repo.repo}/${github.context.runId}/${github.context.runNumber}/${inputs.artifactName}` |
There was a problem hiding this comment.
Suggested change
| ? `${github.context.repo.owner}/${github.context.repo.repo}/${github.context.runId}/${github.context.runNumber}/${inputs.artifactName}` | |
| ? `${github.context.repo.owner}/${github.context.repo.repo}/${github.context.runId}/${github.context.runAttempt}/${inputs.artifactName}` |
There was a problem hiding this comment.
runAttempt doesn't actually exist
There was a problem hiding this comment.
This is my PR to actually add it: actions/toolkit#1027
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
add_run_number
branch
from
e8b82c8 to
078a20d
Compare
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
changed the title
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 5, 2022
Updates our s3 actions to upload and download artifacts to versions that include runAttempt in the prefix for the artifact. This change is mostly to make it so that subsequent re-runs of a workflow do not attempt to grab artifacts from previous runs Coincides with: * seemethere/upload-artifact-s3#4 * seemethere/download-artifact-s3#1 Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: #74576 Approved by: https://github.com/malfet, https://github.com/janeyx99
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 7, 2022
Summary: Updates our s3 actions to upload and download artifacts to versions that include runAttempt in the prefix for the artifact. This change is mostly to make it so that subsequent re-runs of a workflow do not attempt to grab artifacts from previous runs Coincides with: * seemethere/upload-artifact-s3#4 * seemethere/download-artifact-s3#1 Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: #74576 Approved by: https://github.com/malfet, https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2ecc59086a5bc896c82f6f309d25569ec2933467 Reviewed By: b0noI Differential Revision: D35435541 Pulled By: seemethere fbshipit-source-id: 54ac419c21ded23a9c56c7433edf871150a16653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eli Uriegas [email protected]