-
Notifications
You must be signed in to change notification settings - Fork 272
Migrate rokt-audiences to new authentication method #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hi @GoodmanBen thanks for raising this draft PR. |
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Hi @joe-ayoub-segment thank you, this has been tested and is ready for review. Yes, thank you for flagging. We understand that this is a breaking change. This extension is currently in private beta and we have coordinated with the one user on how to transition to the new authentication approach. |
packages/destination-actions/src/destinations/rokt-audiences/upsertCustomAudiences/index.ts
Outdated
Show resolved
Hide resolved
…psertCustomAudiences/index.ts Co-authored-by: Joe Ayoub <[email protected]>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
We're in a deploy freeze so next deploy scheduled for 3-Dec |
* build: migrate to rpub rsec based auth * build: updates for authentication tests * build: small tweaks and test fixes * Update packages/destination-actions/src/destinations/rokt-audiences/upsertCustomAudiences/index.ts Co-authored-by: Joe Ayoub <[email protected]> --------- Co-authored-by: Joe Ayoub <[email protected]>
Testing