Skip to content

Migrate rokt-audiences to new authentication method #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

GoodmanBen
Copy link
Contributor

@GoodmanBen GoodmanBen commented Nov 20, 2024

Testing

  • Updated unit tests for new functionality
  • Tested end-to-end using the local server. Successfully checked authentication and test event submission:
    image
    image
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change. --> This integration is in private beta and we have established a migration plan with the one active private beta user.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

hi @GoodmanBen thanks for raising this draft PR.
I won't review it until you ask me to - however I had a quick scan and noticed that all of the auth settings are changing.
This will be a breaking change, and will prevent any data collection for customers who are already using the Integration.
Customers will need to reconfigure auth settings before data collection to Rokt can resume.
Just want to make sure you are aware of this.

@GoodmanBen GoodmanBen marked this pull request as ready for review November 22, 2024 01:29
@GoodmanBen GoodmanBen requested a review from a team as a code owner November 22, 2024 01:29
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@GoodmanBen
Copy link
Contributor Author

hi @GoodmanBen thanks for raising this draft PR. I won't review it until you ask me to - however I had a quick scan and noticed that all of the auth settings are changing. This will be a breaking change, and will prevent any data collection for customers who are already using the Integration. Customers will need to reconfigure auth settings before data collection to Rokt can resume. Just want to make sure you are aware of this.

Hi @joe-ayoub-segment thank you, this has been tested and is ready for review. Yes, thank you for flagging. We understand that this is a breaking change. This extension is currently in private beta and we have coordinated with the one user on how to transition to the new authentication approach.

…psertCustomAudiences/index.ts

Co-authored-by: Joe Ayoub <[email protected]>
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@joe-ayoub-segment joe-ayoub-segment merged commit 8fa0100 into segmentio:main Nov 26, 2024
10 of 12 checks passed
@joe-ayoub-segment
Copy link
Contributor

We're in a deploy freeze so next deploy scheduled for 3-Dec

@GoodmanBen GoodmanBen deleted the feature/ccd_742 branch November 26, 2024 15:31
julesbravo pushed a commit to Stodge-Inc/segment-destination that referenced this pull request Mar 28, 2025
* build: migrate to rpub rsec based auth

* build: updates for authentication tests

* build: small tweaks and test fixes

* Update packages/destination-actions/src/destinations/rokt-audiences/upsertCustomAudiences/index.ts

Co-authored-by: Joe Ayoub <[email protected]>

---------

Co-authored-by: Joe Ayoub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants