Skip to content

Conversation

wenxi-zeng
Copy link
Contributor

  • move writeKey from auth header to batch body
  • add instanceId to context object

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 78.14% // Head: 78.10% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (91a6b19) compared to base (7fc55c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #121      +/-   ##
============================================
- Coverage     78.14%   78.10%   -0.05%     
+ Complexity      443      440       -3     
============================================
  Files            64       64              
  Lines          5761     5759       -2     
  Branches        725      725              
============================================
- Hits           4502     4498       -4     
  Misses          693      693              
- Partials        566      568       +2     
Impacted Files Coverage Δ
...va/com/segment/analytics/kotlin/core/HTTPClient.kt 81.53% <ø> (-1.08%) ⬇️
...m/segment/analytics/kotlin/core/HTTPClientTests.kt 88.37% <ø> (-0.52%) ⬇️
...tics/kotlin/core/platform/plugins/ContextPlugin.kt 89.47% <100.00%> (+1.23%) ⬆️
...om/segment/analytics/kotlin/core/AnalyticsTests.kt 72.33% <100.00%> (+0.07%) ⬆️
.../analytics/kotlin/core/compat/JavaAnalyticsTest.kt 66.78% <100.00%> (+0.11%) ⬆️
...tics/kotlin/core/platform/plugins/LogTargetTest.kt 70.65% <0.00%> (-1.09%) ⬇️
...n/java/com/segment/analytics/kotlin/core/Events.kt 45.69% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wenxi-zeng wenxi-zeng merged commit 504b948 into main Dec 8, 2022
@wenxi-zeng wenxi-zeng deleted the wenxi/move-writekey-to-body branch December 8, 2022 19:59
@wenxi-zeng wenxi-zeng mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants