Skip to content

Conversation

charleswilliamson7
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Base: 78.32% // Head: 78.51% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (8d17d37) compared to base (4a5d2be).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
+ Coverage     78.32%   78.51%   +0.19%     
- Complexity      477      488      +11     
============================================
  Files            71       73       +2     
  Lines          5914     5962      +48     
  Branches        736      736              
============================================
+ Hits           4632     4681      +49     
+ Misses          708      707       -1     
  Partials        574      574              
Impacted Files Coverage Δ
...segment/analytics/kotlin/core/platform/Mediator.kt 100.00% <ø> (ø)
...om/segment/analytics/kotlin/core/AnalyticsTests.kt 72.01% <ø> (-0.33%) ⬇️
...lin/com/segment/analytics/kotlin/core/StateTest.kt 61.11% <0.00%> (ø)
...in/core/platform/plugins/DestinationPluginTests.kt 93.80% <ø> (ø)
...ava/com/segment/analytics/kotlin/core/Analytics.kt 75.14% <80.00%> (+0.57%) ⬆️
...ics/kotlin/core/platform/plugins/UserInfoPlugin.kt 87.50% <87.50%> (ø)
...in/java/com/segment/analytics/kotlin/core/State.kt 94.23% <100.00%> (+0.11%) ⬆️
...s/kotlin/core/platform/plugins/StartupQueueTest.kt 88.23% <100.00%> (ø)
...otlin/core/platform/plugins/UserInfoPluginTests.kt 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following changes should be made in Analytics:

  1. update userId() to return userId directly from the cache
  2. update userIdAsync to return userId directly from the cache, and mark this function as deprecate, suggest the user to use userId() instead
  3. repeat the 1-2 above for anonymousId

Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@didiergarcia didiergarcia merged commit 1bd4e99 into main Feb 14, 2023
@didiergarcia didiergarcia deleted the chwilliamson/wronguserid branch February 14, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants