-
Notifications
You must be signed in to change notification settings - Fork 33
LIBMOBILE-1060 #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIBMOBILE-1060 #124
Conversation
core/src/main/java/com/segment/analytics/kotlin/core/platform/plugins/UserInfoPlugin.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/segment/analytics/kotlin/core/platform/plugins/UserInfoPlugin.kt
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 78.32% // Head: 78.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
============================================
+ Coverage 78.32% 78.51% +0.19%
- Complexity 477 488 +11
============================================
Files 71 73 +2
Lines 5914 5962 +48
Branches 736 736
============================================
+ Hits 4632 4681 +49
+ Misses 708 707 -1
Partials 574 574
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
core/src/main/java/com/segment/analytics/kotlin/core/platform/plugins/UserInfoPlugin.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the following changes should be made in Analytics:
- update
userId()
to return userId directly from the cache - update
userIdAsync
to return userId directly from the cache, and mark this function as deprecate, suggest the user to useuserId()
instead - repeat the 1-2 above for
anonymousId
core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
No description provided.