Skip to content

Conversation

didiergarcia
Copy link
Contributor

@didiergarcia didiergarcia commented Mar 5, 2023

Adding test that validate that we handle bad Settings Objects from the server.

@didiergarcia didiergarcia requested a review from wenxi-zeng March 5, 2023 01:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage: 71.95% and project coverage change: -0.12 ⚠️

Comparison is base (a762652) 78.51% compared to head (b24cb01) 78.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
- Coverage     78.51%   78.39%   -0.12%     
- Complexity      488      492       +4     
============================================
  Files            73       73              
  Lines          5962     6032      +70     
  Branches        736      757      +21     
============================================
+ Hits           4681     4729      +48     
- Misses          707      708       +1     
- Partials        574      595      +21     
Impacted Files Coverage Δ
...com/segment/analytics/kotlin/core/SettingsTests.kt 81.71% <67.69%> (-8.29%) ⬇️
...n/com/segment/analytics/kotlin/core/utils/Mocks.kt 97.05% <75.00%> (-2.95%) ⬇️
...java/com/segment/analytics/kotlin/core/Settings.kt 75.43% <92.30%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didiergarcia didiergarcia merged commit 477b1ba into main Mar 6, 2023
@didiergarcia didiergarcia deleted the feature/settings-verification branch March 6, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants