Skip to content

Conversation

didiergarcia
Copy link
Contributor

@didiergarcia didiergarcia commented Mar 5, 2023

The sample Kotlin app will crash on screen rotation because we would put null values into the Bundle:

Bundle() { put(..., null) } }

This would cause an issue later as the OS would try to unparcel the bundle and not handle the null value well:

FATAL EXCEPTION: pool-10-thread-6
Process: com.segment.analytics.next, PID: 31741
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.Bundle.unparcel()' on a null object reference

@didiergarcia didiergarcia requested a review from wenxi-zeng March 5, 2023 02:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a762652) 78.51% compared to head (c6e27a0) 78.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #138      +/-   ##
============================================
- Coverage     78.51%   78.49%   -0.02%     
  Complexity      488      488              
============================================
  Files            73       73              
  Lines          5962     5962              
  Branches        736      736              
============================================
- Hits           4681     4680       -1     
  Misses          707      707              
- Partials        574      575       +1     
Impacted Files Coverage Δ
...tics/kotlin/core/platform/plugins/LogTargetTest.kt 70.65% <0.00%> (-1.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didiergarcia didiergarcia merged commit a959c6b into main Mar 6, 2023
@didiergarcia didiergarcia deleted the fix-screen-rotation-bug-kotiln-sample branch March 6, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants