Skip to content

Use a CopyOnWriteArrayList in Mediator instead of synchronized {}. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Use a CopyOnWriteArrayList in Mediator instead of synchronized {}. #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions core/src/main/java/com/segment/analytics/kotlin/core/platform/Mediator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,25 @@ import com.segment.analytics.kotlin.core.Analytics
import com.segment.analytics.kotlin.core.BaseEvent
import com.segment.analytics.kotlin.core.platform.plugins.logger.LogFilterKind
import com.segment.analytics.kotlin.core.platform.plugins.logger.segmentLog
import java.util.concurrent.CopyOnWriteArrayList
import kotlin.reflect.KClass

// Platform abstraction for managing plugins' execution (of a specific type)
// All operations are thread safe via the `synchronized` function
internal class Mediator(internal val plugins: MutableList<Plugin>) {
// All operations are thread safe via the CopyOnWriteArrayList. Which allows multiple
// threads to read the list but when a modification is made the modifier is given a new copy of
// list and that becomes the new version of the list.
// More info: https://developer.android.com/reference/kotlin/java/util/concurrent/CopyOnWriteArrayList
internal class Mediator(internal val plugins: CopyOnWriteArrayList<Plugin>) {

fun add(plugin: Plugin) = synchronized(plugins) {
fun add(plugin: Plugin) {
plugins.add(plugin)
}

fun remove(plugin: Plugin) = synchronized(plugins) {
fun remove(plugin: Plugin) {
plugins.removeAll { it === plugin } // remove only if reference is the same
}

fun execute(event: BaseEvent): BaseEvent? = synchronized(plugins) {
fun execute(event: BaseEvent): BaseEvent? {
var result: BaseEvent? = event

plugins.forEach { plugin ->
Expand All @@ -42,13 +46,13 @@ internal class Mediator(internal val plugins: MutableList<Plugin>) {
return result
}

fun applyClosure(closure: (Plugin) -> Unit) = synchronized(plugins) {
fun applyClosure(closure: (Plugin) -> Unit) {
plugins.forEach {
closure(it)
}
}

fun <T : Plugin> find(pluginClass: KClass<T>): T? = synchronized(plugins) {
fun <T : Plugin> find(pluginClass: KClass<T>): T? {
plugins.forEach {
if (pluginClass.isInstance(it)) {
return it as T
Expand All @@ -57,7 +61,7 @@ internal class Mediator(internal val plugins: MutableList<Plugin>) {
return null
}

fun <T : Plugin> findAll(pluginClass: KClass<T>): List<T> = synchronized(plugins) {
fun <T : Plugin> findAll(pluginClass: KClass<T>): List<T> {
return plugins.filter { pluginClass.isInstance(it) } as List<T>
}
}
11 changes: 6 additions & 5 deletions core/src/main/java/com/segment/analytics/kotlin/core/platform/Timeline.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,19 @@ import com.segment.analytics.kotlin.core.Analytics
import com.segment.analytics.kotlin.core.BaseEvent
import com.segment.analytics.kotlin.core.System
import kotlinx.coroutines.launch
import java.util.concurrent.CopyOnWriteArrayList
import kotlin.reflect.KClass

// Platform abstraction for managing all plugins and their execution
// Currently the execution follows
// Before -> Enrichment -> Destination -> After
internal class Timeline {
internal val plugins: Map<Plugin.Type, Mediator> = mapOf(
Plugin.Type.Before to Mediator(mutableListOf()),
Plugin.Type.Enrichment to Mediator(mutableListOf()),
Plugin.Type.Destination to Mediator(mutableListOf()),
Plugin.Type.After to Mediator(mutableListOf()),
Plugin.Type.Utility to Mediator(mutableListOf())
Plugin.Type.Before to Mediator(CopyOnWriteArrayList()),
Plugin.Type.Enrichment to Mediator(CopyOnWriteArrayList()),
Plugin.Type.Destination to Mediator(CopyOnWriteArrayList()),
Plugin.Type.After to Mediator(CopyOnWriteArrayList()),
Plugin.Type.Utility to Mediator(CopyOnWriteArrayList())
)
lateinit var analytics: Analytics

Expand Down