Skip to content

Conversation

didiergarcia
Copy link
Contributor

Add a bunch of test for Mediator and clean up a few things in it's implementation.

@didiergarcia didiergarcia requested a review from wenxi-zeng March 8, 2023 18:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 99.14% and project coverage change: +0.88 🎉

Comparison is base (dcc140b) 78.30% compared to head (3dfa71c) 79.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #143      +/-   ##
============================================
+ Coverage     78.30%   79.19%   +0.88%     
- Complexity      491      504      +13     
============================================
  Files            73       74       +1     
  Lines          6029     6258     +229     
  Branches        757      760       +3     
============================================
+ Hits           4721     4956     +235     
+ Misses          711      703       -8     
- Partials        597      599       +2     
Impacted Files Coverage Δ
...ent/analytics/kotlin/core/platform/MediatorTest.kt 99.12% <99.12%> (ø)
...segment/analytics/kotlin/core/platform/Mediator.kt 96.66% <100.00%> (+10.45%) ⬆️
...segment/analytics/kotlin/core/platform/Timeline.kt 90.90% <100.00%> (ø)
...n/java/com/segment/analytics/kotlin/core/Events.kt 47.42% <0.00%> (+2.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didiergarcia didiergarcia merged commit 68cebe6 into main Mar 8, 2023
@didiergarcia didiergarcia deleted the add-mediator-tests-and-clean branch March 8, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants