Skip to content

Conversation

didiergarcia
Copy link
Contributor

This fixes an issue where an app update that upgraded from analytics-android to analytics-kotlin would look like a new app install instead of an upgrade.

@didiergarcia didiergarcia requested a review from wenxi-zeng April 12, 2023 16:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (be3d5b6) 79.31% compared to head (342f6fa) 79.38%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #152      +/-   ##
============================================
+ Coverage     79.31%   79.38%   +0.07%     
- Complexity      479      480       +1     
============================================
  Files            74       74              
  Lines          5979     5980       +1     
  Branches        719      719              
============================================
+ Hits           4742     4747       +5     
+ Misses          670      666       -4     
  Partials        567      567              
Impacted Files Coverage Δ
.../java/com/segment/analytics/kotlin/core/Storage.kt 92.59% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didiergarcia didiergarcia merged commit 09ee268 into main Apr 12, 2023
@didiergarcia didiergarcia deleted the fix-update-vs-install-logic branch April 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants