Skip to content

Update passive location plugin 2 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update passive location plugin 2 #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ac4023
Don't set the event.context.location property to anything if we don't…
didiergarcia Oct 27, 2023
12fa57b
Refactor getting last location into function.
didiergarcia Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions ...lin-android-app/src/main/java/com/segment/analytics/next/plugins/PassiveLocationPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.Manifest
import android.annotation.SuppressLint
import android.content.Context
import android.content.pm.PackageManager
import android.location.Location
import android.location.LocationManager
import android.os.Build
import com.segment.analytics.kotlin.core.Analytics
Expand Down Expand Up @@ -38,15 +39,7 @@ class PassiveLocationPlugin(val context: Context) : Plugin {
if (haveAnyLocationPermission()
) {


val locationManager =
context.getSystemService(Context.LOCATION_SERVICE) as LocationManager

@SuppressLint("MissingPermission")
// Passive Provider is API level 8
val passiveLastKnownLocation = locationManager.getLastKnownLocation(
LocationManager.PASSIVE_PROVIDER
)
val passiveLastKnownLocation = getLastKnownLocation()

// Build top-level event.context.location object.
put("location", buildJsonObject {
Expand All @@ -65,8 +58,7 @@ class PassiveLocationPlugin(val context: Context) : Plugin {
JsonPrimitive(passiveLastKnownLocation?.bearingAccuracyDegrees)
)
}



if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
put(
"elapsedRealtimeAgeMillis",
Expand All @@ -79,15 +71,24 @@ class PassiveLocationPlugin(val context: Context) : Plugin {
put("isMock", JsonPrimitive(passiveLastKnownLocation?.isMock))
}
})
} else {
// If we don't have permissions then just set event.context.location = "n/a"
put("location", JsonPrimitive("n/a"))
}
}

return event
}

private fun getLastKnownLocation(): Location? {
val locationManager =
context.getSystemService(Context.LOCATION_SERVICE) as LocationManager

@SuppressLint("MissingPermission")
// Passive Provider is API level 8
val passiveLastKnownLocation = locationManager.getLastKnownLocation(
LocationManager.PASSIVE_PROVIDER
)
return passiveLastKnownLocation
}

/**
* Returns true if we have either Fine or Coarse Location Permission.
*/
Expand Down