Skip to content

Conversation

niallzato
Copy link
Contributor

Adding to our docs how to create the JSON object for implementations supporting a minimum API version below 24.

@codecov-commenter
Copy link

Codecov Report

Merging #84 (a7f1d5c) into main (6c96588) will decrease coverage by 32.67%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main      #84       +/-   ##
=============================================
- Coverage     78.16%   45.49%   -32.68%     
+ Complexity      442       14      -428     
=============================================
  Files            64        8       -56     
  Lines          5478      855     -4623     
  Branches        691       85      -606     
=============================================
- Hits           4282      389     -3893     
+ Misses          650      436      -214     
+ Partials        546       30      -516     
Impacted Files Coverage Δ
...gment/analytics/kotlin/core/utilities/FileUtils.kt
...va/com/segment/analytics/kotlin/core/HTTPClient.kt
...segment/analytics/kotlin/core/platform/Timeline.kt
...m/segment/analytics/kotlin/core/platform/Plugin.kt
...ytics/kotlin/core/platform/plugins/StartupQueue.kt
...om/segment/analytics/kotlin/core/AnalyticsTests.kt
...lin/com/segment/analytics/kotlin/core/StateTest.kt
...n/core/utilities/EventManipulationFunctionsTest.kt
...ics/kotlin/core/platform/DestinationPluginTests.kt
...m/segment/analytics/kotlin/core/HTTPClientTests.kt
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c96588...a7f1d5c. Read the comment docs.

Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Wenxi Zeng <[email protected]>
@wenxi-zeng wenxi-zeng merged commit 5e3e5a9 into main May 19, 2022
@wenxi-zeng wenxi-zeng deleted the niall/add_docs branch May 19, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants