fix shell command built from environment values #1300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analytics-next/packages/browser/scripts/vendor/run.js
Lines 6 to 12 in 80ef0be
Fix the issue will replace the use of
execSync
withexecFileSync
and pass the command arguments separately. This approach avoids shell interpretation of the dynamically constructed command string. Specifically:`yarn webpack --config ${configPath}`
with the commandyarn
and arguments['webpack', '--config', configPath]
.execSync
call to useexecFileSync
with the new command and arguments.This change ensures that the
configPath
value is treated as a literal argument and not subject to shell interpretation.References