Skip to content

fix shell command built from environment values #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odaysec
Copy link

@odaysec odaysec commented May 17, 2025

const { execSync } = require('node:child_process')
const path = require('node:path')
const { createTSFromJSLib } = require('./helpers')
// build tsub.js with webpack
const configPath = path.join(__dirname, 'webpack.config.vendor.js')
execSync(`yarn webpack --config ${configPath}`, { stdio: 'inherit' })

Fix the issue will replace the use of execSync with execFileSync and pass the command arguments separately. This approach avoids shell interpretation of the dynamically constructed command string. Specifically:

  1. Replace the dynamic command string `yarn webpack --config ${configPath}` with the command yarn and arguments ['webpack', '--config', configPath].
  2. Update the execSync call to use execFileSync with the new command and arguments.

This change ensures that the configPath value is treated as a literal argument and not subject to shell interpretation.


References

Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: ce0b3aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant