Skip to content

Use default FirebaseApp instance instead of initialising new one in Firebase plugin #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
debkanchan opened this issue Jul 15, 2023 · 1 comment · Fixed by #17
Closed

Comments

@debkanchan
Copy link
Contributor

For projects that already use Firebase initialising the Firebase app again can cause errors. Furthermore, it requires you to provide one predefined config which can cause an issue for apps that use different Firebase projects based on various app flavors.

It's better to keep firebaseOptions as an optional parameter and use the default initialised firebase project if no firebaseOptions is provided.

@debkanchan debkanchan changed the title Don't Initiliase firebaseapp in firebase plugin Don't Initialise FirebaseApp in firebase plugin Jul 15, 2023
@debkanchan debkanchan changed the title Don't Initialise FirebaseApp in firebase plugin Use default FirebaseApp instance instead of initialising new one in Firebase plugin Jul 16, 2023
@edsonjab
Copy link
Contributor

Hi @DebkanchanSamadder thanks for your report, we reviewed your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants