Skip to content

make firebaseOptions optional for FirebaseDestination plugin #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

make firebaseOptions optional for FirebaseDestination plugin #17

merged 1 commit into from
Jul 24, 2023

Conversation

debkanchan
Copy link
Contributor

@debkanchan debkanchan commented Jul 15, 2023 •
edited
Loading

This pr makes the firebaseOptions an optional param for FirebaseDestination and uses default FirebaseApp instance if no firebaseOptions is provided.

Fixes #16

edsonjab
edsonjab approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@edsonjab edsonjab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine!

@debkanchan
Copy link
Contributor Author

@edsonjab Can we get it merged?

@oscb oscb merged commit 87c9c18 into segmentio:main Jul 24, 2023
@t-unit t-unit mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscb oscb oscb approved these changes

@edsonjab edsonjab edsonjab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use default FirebaseApp instance instead of initialising new one in Firebase plugin
3 participants
@debkanchan @oscb @edsonjab