Change validation to identify once and track app is installed #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscb
suggested changes
Dec 13, 2023
packages/core/lib/analytics.dart
Outdated
| "build": context.app.build, | ||
| }); | ||
| } else if (context.app.version != previousContext.app.version) { | ||
| if (context.app.version != previousContext.app.version) { |
There was a problem hiding this comment.
This won't really fix the Application Installed event not being triggered as this is the only place where this is tracked.
I think the solution should either be:
- Change the initialization of context so that it is
nullat this point. Then we can call the native function to fill the values. - Do a different check at this point to see if the app is just installed. f.e. instead of checking context we can persist a flag.
There was a problem hiding this comment.
My only concern with changing the initialization of Context would be concurrency issues. Specially with plugins like IDFA, AdvertisingID. Not 100% sure if any plugin might be expecting context to be populated from the get-go and hence why it is initialized right away.
The second solution might be simpler and more sound.
edsonjab
changed the title
chrisradek
approved these changes
Dec 19, 2023
oscb
approved these changes
Dec 19, 2023
oscb
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42