Prefer ajs_anonymous_id from cookies to LocalStorage #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QoLTech
force-pushed
the
prefer-cookies-to-local-storage-for-anonymous-id
branch
2 times, most recently
from
9515c99 to
f73fe72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue I'm having here.
If the file we're trying to grab from LocalStorage is userInfo, also try to grab the browser cookies and parse out the "ajs_anonymous_id". If it's not null, replace LocalStorage.anonymousId with the value from the cookie. This allows us to keep our anonymousId tracking consistent across Analytics.js and analytics_flutter.
Your _readFromStorage is generic and I'm introducing changes specific to an individual file, so this probably isn't ideal, but it at least gives you a visualization what I'm trying to do.