Skip to content

Add Video Playback Exited event to Video Spec #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

tobiordobi
Copy link
Contributor

@tobiordobi tobiordobi commented Oct 11, 2021

Proposed changes

A new playback event "Video Playback Exited" was added to some destinations in May but it is not reflected in the Video specs. This change aims to add that to the spec and inform on when to us it. - You can find more details on internal paper-doc "Video Spec Event Proposal for Video Playback Exited".

Example: https://github.com/segment-integrations/analytics-android-integration-nielsen-dcr/blob/master/src/main/java/com/segment/analytics/android/integrations/nielsendcr/NielsenDCRIntegration.java#L474

Merge timing

  • ASAP once approved?

Related issues (optional)

stayseesong and others added 3 commits October 7, 2021 09:18
A new playback event "Video Playback Exited" was added to some destinations in May but it is not reflected in the Video specs. This change aims to add that to the spec and inform on when to us it. - You can find more details on internal paper-doc "Video Spec Event Proposal for Video Playback Exited".

Example: https://github.com/segment-integrations/analytics-android-integration-nielsen-dcr/blob/master/src/main/java/com/segment/analytics/android/integrations/nielsendcr/NielsenDCRIntegration.java#L474
@tobiordobi tobiordobi requested a review from a team as a code owner October 11, 2021 12:53
@markzegarelli markzegarelli changed the base branch from master to develop October 11, 2021 15:40
@markzegarelli markzegarelli changed the title update video spec Add Video Playback Exited event to Video Spec Oct 11, 2021
@markzegarelli markzegarelli merged commit 506abbe into develop Oct 11, 2021
@markzegarelli markzegarelli deleted the tawe-segment-patch-1 branch October 11, 2021 15:41
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@markzegarelli markzegarelli added content When the bug is about content that needs to get fixed enhancement labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content When the bug is about content that needs to get fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants