Skip to content

Update custom-proxy.md SDK initialization #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

PcooperSegment
Copy link
Contributor

A customer pointed out that, before starting with the CDN Proxy setup, they needed to update the SDK initialization within your application first.

Ticket: https://segment.zendesk.com/agent/tickets/510041

Proposed changes

"These instructions refer to Amazon CloudFront, but apply more generally to other providers as well. Once you've updated the SDK initialization in your application, you can proceed with the following steps to set up your CDN Proxy.
(Changing the configuration in the Segment UI before the SDK initialization has been made can result in unexpected changes in app behaviour)"

Before starting with the CDN Proxy setup, customers need to update the SDK initialization within your application first. Changing the configuration in the Segment UI before the SDK initialization has been made can result in unexpected changes in app behaviour.

Merge timing

  • ASAP once approved

Related issues (optional)

N/A

A customer pointed out that, before starting with the CDN Proxy setup, they needed to ensure that you've updated the SDK initialization within your application first.
@PcooperSegment
Copy link
Contributor Author

After reviewing the issue, it's recommended that the change be this instead:

These instructions refer to Amazon CloudFront, but apply more generally to other providers as well. Before changing the Segment UI (Segment tracking API) or the Segment snippet (Segment CDN) to use your new proxy, please ensure that you have completed the custom domain proxy setup on your side to avoid any unexpected behavior.

Updated draft to reflect suggested changed.
@prigiattiperrut prigiattiperrut marked this pull request as ready for review January 27, 2025 14:17
@prigiattiperrut prigiattiperrut requested a review from a team as a code owner January 27, 2025 14:17
forstisabella
forstisabella previously approved these changes Jan 27, 2025
@forstisabella forstisabella merged commit 7abcdbb into develop Jan 27, 2025
1 of 3 checks passed
@forstisabella forstisabella deleted the PcooperSegment-patch-3 branch January 27, 2025 17:02
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants