removed all <p> and </p> in Retries section #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github trying to be too smart for us here. 😆 |
sanscontext
reviewed
Jan 27, 2020
| <td><p><b>Wait Growth</b></p><p>Rate of growth of the sleep duration between each retry</p></td> | ||
| <td><p><b>Max Wait</b></p><p>Maximum sleep duration between retries</p></td> | ||
| <td><p><b>Max Attempts</b></p><p>Maximum number of individual retries</p></td> | ||
| <td><b>Initial Wait</b>Sleep duration before the first retry</td> |
There was a problem hiding this comment.
Can you add a space between the B and the follow on text? Possibly a space-dash-space for separation purposes.
There was a problem hiding this comment.
hm would putting the 2nd non-bolded text in parenthesis be better perhaps?
so
There was a problem hiding this comment.
or would
Initial Wait - Sleep duration before the first retrybe preferred?
There was a problem hiding this comment.
Hm. Functionally for the sighted either would work, but I prefer using the latter (the dash as a separator) because of how it's voiced for screen readers.
sanscontext
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed all
and
in Retries section