Skip to content

Update the Prerequisites steps to include "Destination Filters" #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prigiattiperrut
Copy link
Contributor

Proposed changes

Added a required step to the Prerequisites section, so customers are aware that enabling "Destination Filters" is necessary.

@prigiattiperrut prigiattiperrut requested a review from atitsh June 13, 2024 16:42
@prigiattiperrut prigiattiperrut requested a review from a team as a code owner June 13, 2024 16:42
@prigiattiperrut prigiattiperrut requested review from forstisabella and removed request for a team June 13, 2024 16:42
@atitsh
Copy link
Contributor

atitsh commented Jun 13, 2024

@prigiattiperrut @forstisabella , if i am reading the changes correct, i dont think it is in the suggested spot. I thought we wanted to add this to the Pre-req steps? no?

I think that is the right spot, plus we should call out, if using Analytics.js and Device Mode destination, enable destination filters.

2. On the Consent management page, click **Create categories**.
3. Confirm that you have completed the required prerequisites, and click **Next**.
4. On the Create consent categories page, add the following information to the category form:
1. For Analytics.js sources only - On the Source Settings page, enable **Destination Filters**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. For Analytics.js sources only - On the Source Settings page, enable **Destination Filters**.
1. _For Analytics.js sources only_ : Navigate to your Analytics.js source and select **Settings > Analytics.js**. Enable **Destination Filters**.

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @atitsh - this seems like the right information, but is just in the wrong place. I think you could add this one of two places:

  • In the prerequisites section, as the last step
  • In the section about wrappers, as a note under the link to the A.js wrapper link

@atitsh
Copy link
Contributor

atitsh commented Jun 13, 2024

@forstisabella - i like that, lets move these changes to those 2 places and publish the doc. best to publish a patch now and not wait for next week's tuesday release train.

@forstisabella
Copy link
Contributor

closing this PR, as the information was replicated in #6706. Thank you for catching this issue and drafting the language @prigiattiperrut!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants