-
Notifications
You must be signed in to change notification settings - Fork 364
Added Authvia source for Review #6897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Authvia source for Review #6897
Conversation
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion. Please Review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! once @tcgilbert approves we'll be ready to merge
@pgaur-authvia the docs look good, but we'll hold off on merging until the rest of the source review is completed. I sent some questions in the support ticket, but I will post them here as well:
|
Co-authored-by: Thomas Gilbert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @forstisabella can we get this included in tomorrow's deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! can do @tcgilbert
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Merge timing
Related issues (optional)