Skip to content

Added Authvia source for Review #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

pgaur-authvia
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@pgaur-authvia pgaur-authvia requested a review from a team as a code owner August 2, 2024 15:57
@forstisabella forstisabella requested a review from tcgilbert August 2, 2024 16:02
@forstisabella forstisabella added the new-integration Added a new source or destination label Aug 2, 2024
pgaur-authvia and others added 6 commits August 5, 2024 12:26
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
Update Changes as per the suggestion.

Co-authored-by: forstisabella <[email protected]>
@pgaur-authvia
Copy link
Contributor Author

Update Changes as per the suggestion.

Please Review.

Thanks

@forstisabella forstisabella self-requested a review August 5, 2024 15:39
forstisabella
forstisabella previously approved these changes Aug 5, 2024
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! once @tcgilbert approves we'll be ready to merge

@tcgilbert
Copy link
Contributor

@pgaur-authvia the docs look good, but we'll hold off on merging until the rest of the source review is completed. I sent some questions in the support ticket, but I will post them here as well:

Hi Will and Praveen,

Thanks for submitting the docs, as for reviewing your source, I have a couple questions:

Events

I took a look at the source created in your workspace, but I'm not seeing any events populating in the debugger. I'll need to review some example event payloads, could you please send some data into this source, so I can review?

Segment Region

Have you provided the option for users to select which region you are posting data to (US vs. EU endpoint)? If not, you will need to add this in order for your integration to be available in our EU catalog. More details on this here: https://segment.com/docs/partners/sources/#regional-segment

Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @forstisabella can we get this included in tomorrow's deploy?

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! can do @tcgilbert

@forstisabella forstisabella merged commit 2d70800 into segmentio:develop Aug 12, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants