Skip to content

add first documentation page for destination dynamic yield by mastercard #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

djluis
Copy link
Contributor

@djluis djluis commented Aug 13, 2024

Proposed changes

Adds first documentation page for destination Dynamic yield by Mastercardard audiences

Merge timing

This can be published after we complete the QA tests for Dynamic Yield by Mastercard destination.

@djluis djluis requested a review from a team as a code owner August 13, 2024 14:44
@djluis djluis requested a review from forstisabella August 13, 2024 14:44
@forstisabella forstisabella added the new-integration Added a new source or destination label Aug 13, 2024
tcgilbert
tcgilbert previously approved these changes Aug 14, 2024
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once @forstisabella changes are made

Added suggestions from forstisabella

Co-authored-by: forstisabella <[email protected]>
@djluis
Copy link
Contributor Author

djluis commented Aug 16, 2024

Thanks for the feedback @forstisabella

tcgilbert
tcgilbert previously approved these changes Aug 16, 2024
@djluis djluis dismissed stale reviews from forstisabella and tcgilbert via 0726a8f August 19, 2024 09:35
@forstisabella forstisabella merged commit eefe899 into segmentio:develop Aug 22, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants