Skip to content

Removing group_id from promoted identifiers | IDRES-20 #7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

praveeen1804
Copy link
Contributor

@praveeen1804 praveeen1804 commented Nov 7, 2024

Proposed changes

Removed the group_id from the list of traits and IDs which are automatically promoted to externalIDs. The group_id was removed from the list of auto-promoted IDs here. This PR updates the documentation to align with this.

Merge timing

Related issues (optional)

https://segment.atlassian.net/browse/IDRES-20

@praveeen1804 praveeen1804 marked this pull request as ready for review November 7, 2024 11:42
@praveeen1804 praveeen1804 requested a review from pwseg as a code owner November 7, 2024 11:42
@praveeen1804 praveeen1804 changed the title Removing groupId from promoted identifiers | IDRES-20 Removing group_id from promoted identifiers | IDRES-20 Nov 8, 2024
@pwseg pwseg added the fixed-content fix to content that has outdated or wrong information label Nov 8, 2024
@pwseg pwseg merged commit c73f10b into develop Nov 8, 2024
5 checks passed
@pwseg pwseg deleted the IDRES-20 branch November 8, 2024 15:07
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants