csharp singleton update #7226
Merged
csharp singleton update #7226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenxi-zeng
previously approved these changes
Nov 14, 2024
src/connections/sources/catalog/libraries/server/csharp/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Wenxi Zeng <[email protected]>
wenxi-zeng
previously approved these changes
Nov 14, 2024
|
@stayseesong good to merge? |
|
@pwseg are we good to merge this? Thanks! |
|
@pwseg or @forstisabella are we good to merge this? Thanks! |
forstisabella
requested changes
Dec 10, 2024
src/connections/sources/catalog/libraries/server/csharp/index.md
Outdated
Show resolved
Hide resolved
Once a few small changes are made we'll be g2g 🚀 |
forstisabella
approved these changes
Dec 18, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add warning about singleton management