Skip to content

Update singlestore destination doc #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

psharma-1909
Copy link
Contributor

We need to update the Segment SingleStore destination documentation to reflect the recent changes made in our SingleStore action-destination code.

@psharma-1909 psharma-1909 requested a review from a team as a code owner August 14, 2025 08:33
@psharma-1909 psharma-1909 requested a review from rchinn1 August 14, 2025 08:33
@joe-ayoub-segment
Copy link
Contributor

Hi Docs team. I'm OK for this to be deployed asap.

Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting! I wasn't able to edit the file myself so I left some comments to align this with our docs style guide. After that it looks good to go!

@psharma-1909 psharma-1909 force-pushed the update_singlestore_destination_doc branch 2 times, most recently from 1742f07 to 1e72d81 Compare August 20, 2025 09:02
@psharma-1909 psharma-1909 force-pushed the update_singlestore_destination_doc branch from 1e72d81 to a2a15e8 Compare August 20, 2025 09:04
@psharma-1909
Copy link
Contributor Author

@rchinn1 hey , I have added 1 more commit addressing all the comments.

@psharma-1909 psharma-1909 requested a review from rchinn1 August 20, 2025 09:07
@rchinn1 rchinn1 merged commit 6d6b4d4 into segmentio:develop Aug 20, 2025
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants