Skip to content

multiClose function closes parent modal #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sspread opened this issue Jul 6, 2016 · 3 comments
Closed

multiClose function closes parent modal #1102

sspread opened this issue Jul 6, 2016 · 3 comments

Comments

@sspread
Copy link

sspread commented Jul 6, 2016

I'm using selectize for a 'tagging' feature within a Foundation Reveal modal. When I click the the close button on the 'tag', the modal closes. The issue has something to do with event propagation, and can be fixed by adding return false; to the click handler callback within the multiClose setup function.

This is a duplicate of issue #870

@joallard
Copy link
Member

joallard commented Jul 7, 2016

Okay... since it is a duplicate, we should therefore close it?

@sspread
Copy link
Author

sspread commented Jul 7, 2016

It would make sense to close one of them. I figured it was forgotten, and
likely a quick-ish fix, so I wanted to reraise it.

On Wednesday, July 6, 2016, Jonathan Allard [email protected]
wrote:

Okay... since it is a duplicate, we should therefore close it?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHKAyBMdjDPBhnHfNJabYkOpT0g342Zzks5qTHJ0gaJpZM4JGk-F
.

@joallard
Copy link
Member

joallard commented Jul 7, 2016

Okay, well, that's not exactly useful. What would be useful would be suggesting a well-thought out solution/changes to the code. You can do that on the original issue.

@joallard joallard closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants