Added spellcheck to the list of inherited input attributes #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now inherit `spellcheck` attributes, just as it inherits the `autocorrect` and `autocapitalize` attributes from input elements. Especially helpful in Safari. Fixes issue raised in selectize#1403
|
Note that one test was failing, but not due to the changes I made. The test that's failing is detailed here: #1353 (comment) |
|
Resolved merge conflict. @joallard Any chance we could get this PR merged? It's a fairly simple change that fixes a UI problem on Safari (and probably other) browsers, by inheriting the
|
|
Can you confirm the tests pass on your end? |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now inherit
spellcheckattributes, just as it inherits theautocorrectandautocapitalizeattributes from input elements. Especially helpful in Safari.Fixes issue raised in #1403