-
Notifications
You must be signed in to change notification settings - Fork 142
fix(deps): switch to tinyglobby #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@babblebey @travi @gr2m would I be able to get a review on this PR? It's a bit difficult to keep it updated to avoid merge conflicts since rennovate is constantly updating the lockfile. Thanks! |
Yeah, it's good to be thoughtful about dependency changes. In case it helps, here are the top 10 packages using both libraries. Overall, I'd say that the most popular packages are leaning towards using I'll also note that you don't have to just trust Sindre, but all 14 people who have access to publish
|
55ea34f
to
f4142e6
Compare
Great assessment, thank you for doing the research. Let me talk to @travi to have another set of eyes, but I'm in favor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
87ebf6b
to
2e13b48
Compare
hey @gr2m, sorry it took me a little while to get back to this, but I've fixed the merge conflict now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 11.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
https://npmgraph.js.org/?q=globby - 23 dependencies