Skip to content

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented May 7, 2025

@benmccann
Copy link
Contributor Author

benmccann commented Jun 26, 2025

@babblebey @travi @gr2m would I be able to get a review on this PR? It's a bit difficult to keep it updated to avoid merge conflicts since rennovate is constantly updating the lockfile. Thanks!

@gr2m
Copy link
Member

gr2m commented Jun 27, 2025

The number of dependencies is not a problem, especially if both globby and and all of its sub dependencies are quite established and from @sindresorhus whom we know and trust.

tinyglobby seems to be widely used as well, but we would have to investigate thoroughly before we expose us to a new 3rd party injection attack vector. So I'm not saying no, we are just being careful

@benmccann
Copy link
Contributor Author

benmccann commented Jun 27, 2025

Yeah, it's good to be thoughtful about dependency changes. In case it helps, here are the top 10 packages using both libraries. Overall, I'd say that the most popular packages are leaning towards using tinyglobby, but globby has more downloads overall as it takes awhile for people to upgrade their packages and become aware of newer packages.

I'll also note that you don't have to just trust Sindre, but all 14 people who have access to publish globby or one of its dependencies as compared to only 6 for tinyglobby. I generally think that everyone involved in both packages and their dependencies is quite trustworthy, but am more worried about compromised machines/credentials. The more people with the ability to publish, the more attack surface area exists.

# Downloads Package Note
1 107.99M vite
2 78.69M node-gyp
3 52.53M eslint-import-resolver-typescript
4 42.00M vitest
5 39.83M copy-webpack-plugin
6 14.24M @oclif/core
7 11.97M @nx/js
8 9.67M @vitest/ui
9 8.14M lerna
10 8.06M @lerna/create
# Downloads Package Note
1 62.34M del Sindre's package
2 22.99M react-dev-utils deprecated
3 22.93M stylelint blocked on migrating until they cut a new major
4 18.45M @graphql-tools/graphql-file-loader
5 17.61M @graphql-tools/json-file-loader
6 16.26M @graphql-tools/code-file-loader
7 9.54M @storybook/codemod they're investigating switch and already switched another package to tinyglobby during dependency cleanup update: they've now moved to tinyglobby
8 9.39M @semantic-release/github this package
9 8.44M @storybook/cli they're investigating switch and already switched another package to tinyglobby during dependency cleanup
10 7.80M cpy Sindre's package

@benmccann benmccann force-pushed the tinyglobby branch 3 times, most recently from 55ea34f to f4142e6 Compare June 28, 2025 02:58
@gr2m
Copy link
Member

gr2m commented Jul 17, 2025

Great assessment, thank you for doing the research. Let me talk to @travi to have another set of eyes, but I'm in favor.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay. Could you fix the merge conflict? Otherwise it's good to go!

@benmccann
Copy link
Contributor Author

benmccann commented Sep 9, 2025

hey @gr2m, sorry it took me a little while to get back to this, but I've fixed the merge conflict now

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gr2m gr2m changed the title chore(deps): switch to tinyglobby fix(deps): switch to tinyglobby Sep 11, 2025
@gr2m gr2m enabled auto-merge (squash) September 11, 2025 04:19
@gr2m gr2m merged commit ed90698 into semantic-release:master Sep 11, 2025
6 checks passed
Copy link

🎉 This PR is included in version 11.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants