Improve 'cache restore' command #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyoung-confluent
force-pushed
the
restore-faster
branch
from
b5e60db to
957f244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the
cache restorecommand is used with a key that does not exist in the storage backend it will fallback to doing a more expensive "list" of all keys, attempting to perform a regex match. If multiple keys are provided it will call list for each one of these keys.This PR improves the behavior by skipping the regex matching and just using
strings.Containsif the key does not contain regex characters (ex:*). Additionally, it caches the results of the "list" for use when matching multiple keys as well as the compiled regex expression itself.