Skip to content

Cache default httpclient #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Conversation

nillis
Copy link
Contributor

@nillis nillis commented Nov 23, 2016

No description provided.

@thinkingserious
Copy link
Contributor

Hello @nillis,

Thank you for the PR!

We will be reviewing this PR soon, in the mean time, if you have not, please be sure to sign our CLA so that we can merge your changes. Thanks again!

Team DX

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio status: cla needed labels Nov 23, 2016
@nillis
Copy link
Contributor Author

nillis commented Nov 23, 2016

#17

@nillis nillis changed the title #17 Cache default httpclient Cache default httpclient Nov 23, 2016
@thinkingserious
Copy link
Contributor

Hi @nillis,

I believe the test is failing because private static HttpClient _httpClient = new HttpClient(); should be in the Client class rather than the Response class.

@nillis
Copy link
Contributor Author

nillis commented Nov 29, 2016

Idd, my bad. New build is running :)

@thinkingserious
Copy link
Contributor

Perfect, thanks for the quick fix!

Now, we just need a signed CLA from you in order to review and merge. Thanks again!

@pkarlapu
Copy link

Hey..Now that this is merged to master, I am wondering when would a new version of NuGet be released.

@thinkingserious
Copy link
Contributor

Hi @karlapudipradeep,

You should be able to access this version here: https://www.nuget.org/packages/SendGrid.CSharp.HTTP.Client/3.1.0

With Best Regards,

Elmer

@pkarlapu
Copy link

@thinkingserious Cool..Thanks! I mistook this commit as a commit to https://github.com/sendgrid/sendgrid-csharp repo and was excited for a little bit. It seems like there is an issue opened for the other repo at sendgrid/sendgrid-csharp#405. I will try sending a pull request for it when I get a chance.

@thinkingserious
Copy link
Contributor

@pkarlapu,

I'm actually reviewing that PR right now: sendgrid/sendgrid-csharp#417 :)

Your feedback would be greatly appreciated. Thanks!

@nillis nillis deleted the patch-1 branch April 6, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants