Skip to content

Added support for .Net Core. Fixes #1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Added support for .Net Core. Fixes #1 #3

wants to merge 4 commits into from

Conversation

PaitoAnderson
Copy link

@PaitoAnderson PaitoAnderson commented Apr 22, 2016

Notes:

@thinkingserious
Copy link
Contributor

This is awesome @PaitoAnderson!

For us to merge your pull request, we will need a signed CLA: https://github.com/sendgrid/csharp-http-client/blob/master/CONTRIBUTING.md#cla

Once you have done that, we'll review for a merge.

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla needed labels May 19, 2016
@PaitoAnderson
Copy link
Author

@thinkingserious Thanks, Signed Contributor Agreement has been emailed.

@thinkingserious thinkingserious added status: cla signed status: code review request requesting a community code review or review from Twilio and removed status: cla needed labels May 20, 2016
@thinkingserious
Copy link
Contributor

Hello @PaitoAnderson,

Your signed CLA is received and this pull request is now queued for review. Thanks!

With Best Regards,

Elmer

@cleftheris
Copy link

What is the status on this one. It seems that it has been stalled.

@thinkingserious
Copy link
Contributor

@cleftheris please see my response here: sendgrid/sendgrid-csharp#221 (comment)

@thinkingserious thinkingserious mentioned this pull request Jun 28, 2016
@PaitoAnderson PaitoAnderson changed the title Added support for ASP.Net Core. Fixes #1 Added support for .Net Core. Fixes #1 Jun 29, 2016
@thinkingserious
Copy link
Contributor

Hello @PaitoAnderson,

This has finally bubbled to the top of my queue. Do you mind fixing the conflicts so I can test and merge?

Thanks!

@colltoaction
Copy link

Would be great to have .NET Core support, LGTM :)

@thinkingserious
Copy link
Contributor

@PaitoAnderson @tinchou,

Any thoughts on this comment: sendgrid/sendgrid-csharp#221 (comment)?

@colltoaction
Copy link

Thanks, I didn't realize there were two projects for .NET!

On Wed, Sep 28, 2016 at 1:28 PM Elmer Thomas [email protected]
wrote:

@PaitoAnderson https://github.com/PaitoAnderson @tinchou
https://github.com/tinchou,

Any thoughts on this comment: sendgrid/sendgrid-csharp#221 (comment)
sendgrid/sendgrid-csharp#221 (comment)
?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9Ma3r5NftDvd-3JMOcg2X0-pxnHwks5qupWtgaJpZM4INPcZ
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants