Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Assert file exists #57

Closed
mbernier opened this issue Oct 28, 2017 · 2 comments · Fixed by #58
Closed

Assert file exists #57

mbernier opened this issue Oct 28, 2017 · 2 comments · Fixed by #58
Labels
difficulty: easy

Comments

@mbernier
Copy link
Contributor

Issue Summary

@mptap I am curious if you would be interested in switching these if statements over to test assertions? https://github.com/sendgrid/nodejs-http-client/blob/master/test/test.js

I really like how the tests you created in sendgrid/smtpapi-nodejs#60 ended up displaying in Travis. That would be amazing to have here too.
@mptap
Copy link
Contributor

mptap commented Oct 28, 2017 •
edited
Loading

@mbernier: Sure thing, here you go! PR: #58

@mptap mptap mentioned this issue Oct 28, 2017
Merged
6 tasks
@mbernier
Copy link
Contributor Author

Ohhhh yeah!! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
difficulty: easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Refactored unittest to check for specific repo files to use assert mptap/nodejs-http-client
2 participants
@mbernier @mptap