Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

chore: #94 | Upgrade dev dependency mocha to patch security vulnerabilitiy #101

Merged
merged 3 commits into from
Oct 29, 2018

Conversation

robincher
Copy link
Contributor

@robincher robincher commented Oct 12, 2018

Fixes #94

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Bump Mocha testing library to version 4 (or latest 5.2)
  • Update package lock file

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@robincher robincher changed the title #94 | Upgrade dev dependency mocha to version 4 #94 | Upgrade dev dependency mocha to patch security vulnerabilitiy Oct 12, 2018
@thinkingserious
Copy link
Contributor

Hello @robincher,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 306db08 into sendgrid:master Oct 29, 2018
@thinkingserious
Copy link
Contributor

Hello @robincher,

Thanks again for the PR!

You have earned 6 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious changed the title #94 | Upgrade dev dependency mocha to patch security vulnerabilitiy chore: #94 | Upgrade dev dependency mocha to patch security vulnerabilitiy Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security vulnerability for [email protected]
3 participants