Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Fixes #13: Adds TROUBLESHOOTING.md #31

Closed
wants to merge 1 commit into from
Closed

Fixes #13: Adds TROUBLESHOOTING.md #31

wants to merge 1 commit into from

Conversation

aa-dit-yuh
Copy link

@aa-dit-yuh aa-dit-yuh commented Oct 23, 2017 •
edited
Loading

Fixes #13

@SendGridDX
Copy link

SendGridDX commented Oct 23, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

Hey @narayanaditya95 it looks like #30 beat you to it by minutes, I am sorry about that!

@mbernier mbernier closed this Oct 24, 2017
@aa-dit-yuh
Copy link
Author

aa-dit-yuh commented Oct 24, 2017 •
edited
Loading

Sorry to be picky but #30's commit is after mine.

screen shot 2017-10-24 at 8 51 09 am

The commit happened after the label was added, which happened at 11:40+05.30. My commit was pushed at 11:32+05.30. Moreover, his commit is largely inspired from mine. His original commit (the one pushed while opening the PR at 11:21+05.30) had no headers or TOC.

@mukulmishra18
Copy link
Contributor

#30's commit is after mine.

It appears after the label because I squashed the commits after adding some more code(when I looked into other TROUBLESHOOTING.md file), so that PR does not look noisy. Please refers https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History to learn about squashing commits.

@aa-dit-yuh
Copy link
Author

I know you squashed commits. My point still holds. But nevermind.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aa-dit-yuh @SendGridDX @mbernier @mukulmishra18 @thinkingserious