Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

docs: related to #36 : added the .env_sample and instructions in the readme to configure it #46

Merged
merged 2 commits into from
Oct 29, 2017

Conversation

psnmissaka
Copy link
Contributor

Relates to #36
*Added a sample .env file for users to configure the SendGrid api key.
*Included dotenv package to load the environment variables from .env file
*Added instructions in the readme file to setup the environment variables and to configure API key in the .env file

@SendGridDX
Copy link

SendGridDX commented Oct 27, 2017

CLA assistant check
All committers have signed the CLA.

@psnmissaka psnmissaka changed the title realted to #36 : added the .env_sample and instructions in the readme to configure it related to #36 : added the .env_sample and instructions in the readme to configure it Oct 27, 2017
README.md Outdated
- Once you have obtained the API key, find the environment variable SENDGRID_API_KEY and assign your API key as it's value.
As an example it should look like this
```
SENDGRID_API_KEY='Ef34Gyt&dfPFC34G';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this to a placeholder like so:

SENDGRID_API_KEY='<YOUR_API_KEY>';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the placeholder as requested with the latest commit

@mbernier
Copy link
Contributor

This does exactly what we were looking for. Thank you!

In this case, it's a good thing to have a broken build!

@mbernier mbernier merged commit 56531b9 into sendgrid:master Oct 29, 2017
@thinkingserious
Copy link
Contributor

Hello @psnmissaka,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@psnmissaka
Copy link
Contributor Author

you are welcome @thinkingserious i'm glad to be able to contribute. I just filled the form as well.

@thinkingserious thinkingserious changed the title related to #36 : added the .env_sample and instructions in the readme to configure it docs: related to #36 : added the .env_sample and instructions in the readme to configure it Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants